Skip to content

Update Huawei VRP display vlan #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

evilmonkey19
Copy link
Contributor

Adding support for AP. I accept suggestions for VLAN_ID and VLAN_TYPE

@evilmonkey19 evilmonkey19 marked this pull request as draft February 8, 2025 12:16
@evilmonkey19
Copy link
Contributor Author

This templates are for Huawei VRP platform, which is used in Huawei Switches and APs. The command display vlan is used in both platforms, but they have similar but not exactly the same values. Also I decided to use a more common approach on display vlan imitating show etherchannel brief from cisco IOS.

As well, I added the command display vlan brief which is used in Huawei VRP AP. I reused a template from display vlan.

@evilmonkey19 evilmonkey19 marked this pull request as ready for review February 8, 2025 15:35
@mjbear
Copy link
Collaborator

mjbear commented Feb 8, 2025

This templates are for Huawei VRP platform, which is used in Huawei Switches and APs. The command display vlan is used in both platforms, but they have similar but not exactly the same values. Also I decided to use a more common approach on display vlan imitating show etherchannel brief from cisco IOS.

I'm curious, so I looked but didn't find a template for etherchannel brief, but there is one for summary.

Did I miss something?

Thank you.

As well, I added the command display vlan brief which is used in Huawei VRP AP. I reused a template from display vlan.

@jvanderaa
Copy link
Contributor

I'm working on getting some additional eyes on this one. This does look like a breaking change at the moment. Which then we need to do a major release here soon.

@itdependsnetworks
Copy link
Contributor

What information does bried have that hte regular does not? In general, I regret supporting things like "show cdp neighbors" and "show cdp neighbors details". It's extra work and you get everything from details, no exceptions. The compute cost of a few extra lines is so small, it's not worth the development effort and upkeep.

@evilmonkey19
Copy link
Contributor Author

The issue here is not that we are adding extra little details. Myself, I'm configuring Huawei AP and Huawei switches (VRP). Both cases they do have SSH and in both cases the command is the same. However the output isn't, that's why I suggest doing that.

Also, I wanted to make the command more standard similar to show etherchannel brief (or similar).

@mjbear
Copy link
Collaborator

mjbear commented Feb 17, 2025

The issue here is not that we are adding extra little details. Myself, I'm configuring Huawei AP and Huawei switches (VRP). Both cases they do have SSH and in both cases the command is the same. However the output isn't, that's why I suggest doing that.

Also, I wanted to make the command more standard similar to show etherchannel brief (or similar).

What Ken is suggesting is that we shouldn't unnecessarily create templates for the "brief" or "summary" commands (or their vendor/platform equivalents).

A template for the normal or detailed version of the command means one template that provides the same information (and more) plus it means one template to maintain and not two in the long term.

@mjbear mjbear changed the title Updating template Huawei VRP: display vlan Update Huawei VRP display vlan Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants