-
Notifications
You must be signed in to change notification settings - Fork 756
Update Huawei VRP display vlan #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Huawei VRP display vlan #2016
Conversation
Co-authored-by: Michael Bear <[email protected]>
This templates are for Huawei VRP platform, which is used in Huawei Switches and APs. The command As well, I added the command |
I'm curious, so I looked but didn't find a template for etherchannel brief, but there is one for summary. Did I miss something? Thank you.
|
I'm working on getting some additional eyes on this one. This does look like a breaking change at the moment. Which then we need to do a major release here soon. |
What information does bried have that hte regular does not? In general, I regret supporting things like "show cdp neighbors" and "show cdp neighbors details". It's extra work and you get everything from details, no exceptions. The compute cost of a few extra lines is so small, it's not worth the development effort and upkeep. |
The issue here is not that we are adding extra little details. Myself, I'm configuring Huawei AP and Huawei switches (VRP). Both cases they do have SSH and in both cases the command is the same. However the output isn't, that's why I suggest doing that. Also, I wanted to make the command more standard similar to |
What Ken is suggesting is that we shouldn't unnecessarily create templates for the "brief" or "summary" commands (or their vendor/platform equivalents). A template for the normal or detailed version of the command means one template that provides the same information (and more) plus it means one template to maintain and not two in the long term. |
display vlan
Adding support for AP. I accept suggestions for VLAN_ID and VLAN_TYPE