Add support to Cisco IOS for 'show vlan group' #2093
Conversation
forrejam
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa and
mjbear
as code owners
|
Please let me know if there is a better way to handle vlan output like this in textfsm
- vlan_group_name: "MULTI_VLAN_TEST_2"
vlan_ids: "761-763, 197, 116, 118" |
Since those VLAN IDs are all on one line, the string capture as you have it is probably the simplest route. If they were on different lines we could have had the chance to use |
| Value Required VLAN_GROUP_NAME (\S+) | ||
| Value VLAN_IDS (\d+.*) | ||
|
|
||
| Start | ||
| ^vlan\s+group\s+${VLAN_GROUP_NAME}\s+:\s+${VLAN_IDS}$$ -> Record |
There was a problem hiding this comment.
I thought about this for a bit ... we've normalized/standardized on VLAN_ID in other templates. For the raw output here there can be one or more VLAN IDs, but that holds true for other templates where VLAN_ID is used (cisco_ios example).
If you agree, please click the "commit suggestions" button to pull my suggestion into your pull request. Thank you!
| Value Required VLAN_GROUP_NAME (\S+) | |
| Value VLAN_IDS (\d+.*) | |
| Start | |
| ^vlan\s+group\s+${VLAN_GROUP_NAME}\s+:\s+${VLAN_IDS}$$ -> Record | |
| Value Required VLAN_GROUP_NAME (\S+) | |
| Value VLAN_ID (\d+.*) | |
| Start | |
| ^vlan\s+group\s+${VLAN_GROUP_NAME}\s+:\s+${VLAN_ID}$$ -> Record |
There was a problem hiding this comment.
Yep that's fine. The only thing I would say about the use of VLAN_ID in other templates is usually you can rely on it being a single vlan (\d+) so I thought using a different identifier would prompt the user that it will need more post processing (which is what I'm doing in production) in the event of a vlan range. But I can see in the example you linked its not always the case.
There was a problem hiding this comment.
so I thought using a different identifier would prompt the user that it will need more post processing (which is what I'm doing in production) in the event of a vlan range.
You have a good point there to differentiate and call out the need for post processing.
We can certainly get some input from others.
Co-authored-by: Michael Bear <[email protected]>
Add support for "show vlan group" on cisco IOS