Skip to content

Cisco IOS 'show ip bgp summary' neighbor ASDOT format #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kolbashj
Copy link

@kolbashj kolbashj commented Apr 7, 2025

Allow Cisco IOS 'show ip bgp summary' to capture NEIGHBOR_AS as either standard or ASDOT notation.

LOCAL_AS pattern updated in issue 986 PR987, but did not include NEIGHBOR_AS.

@mjbear
Copy link
Collaborator

mjbear commented Apr 10, 2025

@kolbashj
We also need test data included in this PR.

Please provide bgp summary test data that includes ASNs in asdot format. It is perfectly fine to obfuscate or modify anything that could be deemed "sensitive" information.

Example file name (doesn't exist until you create it) to place it in:
tests/cisco_ios/show_ip_bgp_summary/cisco_ios_show_ip_bgp_summary_asdot.raw

As long as you put the raw data in the correct spot, you can use helper scripts to generate the structured data (yaml).

The test data is in a new file necessary so that we can make sure the template is backwards compatible in the future when more changes are needed.

🎯 Please respond back if there are any questions. Thank you!

@mjbear mjbear added the status: action required This issue requires additional information to be actionable label Apr 10, 2025
@kolbashj
Copy link
Author

Hello @mjbear

I just added the test data results. Please let me know if I missed anything. Appreciate your help!

@mjbear
Copy link
Collaborator

mjbear commented Apr 10, 2025

I just added the test data results. Please let me know if I missed anything. Appreciate your help!

This looks good.

I noticed the existing test data was not in alphabetic order. While we're working on a PR I figure we may as well get the keys reordered alphabetically. 😀

Thank you!

@mjbear mjbear removed the status: action required This issue requires additional information to be actionable label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants