upsstats*.html.sample: Enhance model detection in upsstats HTML templates #3180
+39
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates. Some devices lack `ups.model`, causing the CGI to incorrectly report "Not supported". Signed-off-by: Atanas Vladimirov <[email protected]>
Signed-off-by: Atanas Vladimirov <[email protected]>
|
❌ Build nut 2.8.4.3769-master failed (commit b601286591 by @atanas-vladimirov) |
jimklimov
approved these changes
Nov 12, 2025
| @REFRESH@ | ||
| <title>@HOSTDESC@ : @VAR ups.model@ on @HOST@</title> | ||
| <title> | ||
| @HOSTDESC@ : |
Member
There was a problem hiding this comment.
Did you check if any rendering aspects change in title or table cells that have now added the sort of whitespace around text in their contents? They were like "closing angle bracket"-"evaluated string" and now there's an end of line in-between...
Contributor
Author
There was a problem hiding this comment.
Yes, I have double-checked how it looks after the change(s) - you can see it here - https://hodor.bsdbg.net/cgi-bin/nut/upsstats.cgi
Member
There was a problem hiding this comment.
Thanks for the link, looks good :)
jimklimov
approved these changes
Nov 12, 2025
| @REFRESH@ | ||
| <title>@HOSTDESC@ : @VAR ups.model@ on @HOST@</title> | ||
| <title> | ||
| @HOSTDESC@ : |
Member
There was a problem hiding this comment.
Thanks for the link, looks good :)
…ols#3180] Signed-off-by: Jim Klimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices lack
ups.model, causing the CGI to incorrectly report "Not supported".Tested on Masterguard A1000.
Signed-off-by: Atanas Vladimirov [email protected]