Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 5.0 And Python 3.12 Compatibility #140

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

ckarli
Copy link
Contributor

@ckarli ckarli commented Dec 7, 2023

Removed Python 3.7 as it's deprecated

@jerch
Copy link
Collaborator

jerch commented Dec 7, 2023

@ckarli Does not work yet with django 5. The tests fail at Model.objects.create ending up at:

ValueError: Model instances passed to related filters must be saved.

Had no time yet to look into django 5 changes. On a sidenote - I remember seeing something similar for backrelations starting to require a pk around 4.1 or 4.2, which was not the case before.

@jerch
Copy link
Collaborator

jerch commented Dec 7, 2023

Btw you can also remove the django 3.2 tests, I am not keen to cover more than one LTS version in the long run.

@martinlehoux
Copy link
Contributor

Looks like a deprecation django/django@4d78d73

@martinlehoux
Copy link
Contributor

Looks like it was in Django 4.1 https://docs.djangoproject.com/en/5.0/releases/4.1/

Anyway, this is an error in the example project, I suggest to update the exampleapp

@martinlehoux
Copy link
Contributor

I made a PR on your PR ckarli#1

With this all tests succeed, all tests pass, except the psycopg3 matrix

fix: update example app and tests to comply to django 5
@jerch
Copy link
Collaborator

jerch commented Jan 19, 2024

Trying to fix the docs madness in #141 - once thats merged into master, plz apply it here as well.

@martinlehoux
Copy link
Contributor

Yes I saw that, I ignored it but thanks for the fix ;)

@jerch
Copy link
Collaborator

jerch commented Jan 19, 2024

Guess thats the downside of rolling software package releases 😅 I simply tagged it with the last working version for now and re-ordered the test execution to see at least, whether the unit tests pass.

Copy link
Collaborator

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna merge the PR, as it works now. The remaining psycopg3 error comes from strict versioning of the CI env, which is already fixed in master. No need to go the long path with another PR-PR.

Thx @ckarli & @martinlehoux for looking into this 👍

@jerch jerch merged commit f1443fc into netzkolchose:master Jan 19, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants