-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django 5.0 And Python 3.12 Compatibility #140
Conversation
And Deprecate Python 3.7
@ckarli Does not work yet with django 5. The tests fail at
Had no time yet to look into django 5 changes. On a sidenote - I remember seeing something similar for backrelations starting to require a pk around 4.1 or 4.2, which was not the case before. |
Btw you can also remove the django 3.2 tests, I am not keen to cover more than one LTS version in the long run. |
Looks like a deprecation django/django@4d78d73 |
Looks like it was in Django 4.1 https://docs.djangoproject.com/en/5.0/releases/4.1/ Anyway, this is an error in the example project, I suggest to update the exampleapp |
I made a PR on your PR ckarli#1 With this all tests succeed, all tests pass, except the psycopg3 matrix |
fix: update example app and tests to comply to django 5
Trying to fix the docs madness in #141 - once thats merged into master, plz apply it here as well. |
Yes I saw that, I ignored it but thanks for the fix ;) |
Guess thats the downside of rolling software package releases 😅 I simply tagged it with the last working version for now and re-ordered the test execution to see at least, whether the unit tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna merge the PR, as it works now. The remaining psycopg3 error comes from strict versioning of the CI env, which is already fixed in master. No need to go the long path with another PR-PR.
Thx @ckarli & @martinlehoux for looking into this 👍
Removed Python 3.7 as it's deprecated