Improve error message on bad datatype combination. #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #537 by improving the error message. #537 highlights that the
alland single datatypes can be selected in the custom transfer screen at the same time. The resulting error message is confusing.@alessandrofelder do you think this (error message below) is clearer? I tried to change the checkboxes themselves such that only one of these options at a time can be selected. It's possible, but becomes a little complex in terms of the code and making clear to the user why boxes are automatically becoming checked / unchecked.I think an error alone is workable 🤔, if the message is very clear.