feat: add bidirectional option to filter_by_displacement

[demoncoder-crypto]

Mentioned Pr
Bi-directional approach
First Stage commit
Not yet implemnted - edge cases, i.e. what happens if a point keeps jumping back-and-forth between two positions, in that case it's also hard to decide which position is correct. yet to be implemented as mentioned by @niksirbi.

[codecov]

Codecov Report

Attention: Patch coverage is 43.33333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 98.92%. Comparing base (956faf3) to head (e1d536e).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
movement/filtering.py	43.33%	17 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##              main     #531      +/-   ##
===========================================
- Coverage   100.00%   98.92%   -1.08%     
===========================================
  Files           28       28              
  Lines         1549     1575      +26     
===========================================
+ Hits          1549     1558       +9     
- Misses           0       17      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[demoncoder-crypto]

How did pre-commit.ci fail When I only resolved conflicts from github editor? I didn't even push new code. Do I need to push again @niksirbi?

[niksirbi]

@demoncoder-crypto the CI failure is coming from this line. Not sure how that crept in, but you have to remove it.

[niksirbi]

I suspect that your branch name was somehow left in the file after you resolved the merge.

[demoncoder-crypto]

Makes sense. I will resolve it and Push the code again. I just formatted everything in my computer yesterday night so it might take some time to get it up. Thanks for response

[demoncoder-crypto]

[demoncoder-crypto]

Now the ruff commit is passing locally but when I push and resolve conflict it starts failing I am lost now

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[niksirbi]

Now the ruff commit is passing locally but when I push and resolve conflict it starts failing I am lost now

Make sure that the pre-commit you have locally is up-to-date with the one used in CI. In practice, this means running:

pre-commit autoupdate
pre-commit run -a

If pre-commit makes any changes, make sure to stage, commit and push them.

[demoncoder-crypto]

Understood thanks

[demoncoder-crypto]

any other changes needed? And is there a way to make the remaining 3 tests pass?

[harsh-bhanushali-05]

Hey @demoncoder-crypto,
Just to answer your question about failing testcases

1. Sonar Cloud is failing due to unreachable code in filtering.py. ( The raise logger.error( ValueError) on line 286 and 366 to be specific)

2. Codecov is failing as there are lines in the code that have not been been tested. codecov you can find the lines that have not been tested here marked in red.

hope it helps!