Fix RxD MultiCompartment Reactions with different number of source and destination terms.#3805
Fix RxD MultiCompartment Reactions with different number of source and destination terms.#3805adamjhn wants to merge 4 commits into
Conversation
… were not copied correctly when the number of sources and destinations were not equal.
|
✔️ cb5ec30 -> Azure artifacts URL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3805 +/- ##
==========================================
- Coverage 68.45% 68.43% -0.03%
==========================================
Files 688 688
Lines 111300 111300
==========================================
- Hits 76187 76163 -24
- Misses 35113 35137 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| / molecules_per_mM_um3 | ||
| for s, si in zip(dests_ecs, sources_indices) | ||
| for s in dests_ecs | ||
| for si in sources_indices |
There was a problem hiding this comment.
I don't think this can be right. The line that uses s and si seems like they should go together in pairs, but this has us doing all possible pairwise combinations. At a minimum, this changes the behavior when the lists are the same size (e.g., if both were of length 2, before we'd have two entries in the list comprehension; this would give 4.
|
|
||
| h, rxd, data, save_path = neuron_instance | ||
| dend = h.Section(name="dend") | ||
| cyt = rxd.Region(h.allsec(), name="cyt", nrn_region="i") |
There was a problem hiding this comment.
Generally, I'm opposed to allsec on principle. Why not just call it [dend]?
| multiplier array for other reactions.""" | ||
|
|
||
| h, rxd, data, save_path = neuron_instance | ||
| dend = h.Section(name="dend") |
| / molecules_per_mM_um3 | ||
| for s, di in zip(sources_ecs, dests_indices) | ||
| for s in sources_ecs | ||
| for di in dests_indices |
There was a problem hiding this comment.
I don't think this can be right. The line that uses s and di seems like they should go together in pairs, but this has us doing all possible pairwise combinations. At a minimum, this changes the behavior when the lists are the same size (e.g., if both were of length 2, before we'd have two entries in the list comprehension; this would give 4.
|
|
✔️ 59b8666 -> Azure artifacts URL |
2 participants
No description provided.