Skip to content

Conversation

@rnorth
Copy link
Contributor

@rnorth rnorth commented Nov 5, 2025

@annettejanewilson actually deserves the credit for spotting this 😄

Unless the definition of bytes or GB is unusual, dividing by 10e8 doesn't seem right!

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
    • The docs show an incorrect (and thus misleading) example query
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
    • Ought to be reasonably self-apparent
  • If your issue relates to an existing GitHub issue, please link to it.
    • No it does not.

@annettejanewilson actually deserves the credit for spotting this 😄

Unless the definition of bytes or `GB` is unusual, dividing by `10e8` doesn't seem right!
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Hi @rnorth 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Please ensure the propsed changes look good by building it first in your local environment. Refer to this contribution guide to get the site up and running in your local.

If you really require a preview url, reach out to one of the writers and they will generate one for you.

@CLAassistant
Copy link

CLAassistant commented Nov 5, 2025

CLA assistant check
All committers have signed the CLA.

@rnorth
Copy link
Contributor Author

rnorth commented Nov 5, 2025

In contact with our legal team about signing the CLA..!

@adutta-newrelic
Copy link
Contributor

Hello @rnorth Could you please update the status of signing the CLA, so that we can go ahead and review this PR.

@rnorth
Copy link
Contributor Author

rnorth commented Nov 10, 2025

Sorry @adutta-newrelic, this is taking longer than I thought! If anybody chose to raise a separate PR to address the issue, I'd be happy to close this one.

I will update here as soon as I'm able to, though.

@rnorth
Copy link
Contributor Author

rnorth commented Nov 17, 2025

@adutta-newrelic thanks for your patience - I've signed the CLA now.

@cbehera-newrelic cbehera-newrelic self-assigned this Nov 17, 2025
@cbehera-newrelic cbehera-newrelic added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Nov 17, 2025
Copy link
Contributor

@cbehera-newrelic cbehera-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cbehera-newrelic cbehera-newrelic merged commit 793d115 into newrelic:develop Nov 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants