-
Notifications
You must be signed in to change notification settings - Fork 22
feat: add support for entity guid in health #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
- Coverage 69.64% 68.51% -1.14%
==========================================
Files 46 53 +7
Lines 2840 3398 +558
==========================================
+ Hits 1978 2328 +350
- Misses 695 850 +155
- Partials 167 220 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| - name: Download minikube | ||
| run: | | ||
| if test "${{ matrix.k8sVersion }}" == "v1.33.4" || test "${{ matrix.k8sVersion }}" == "v1.32.8" || test "${{ matrix.k8sVersion }}" == "v1.31.12" || test "${{ matrix.k8sVersion }}" == "v1.29.15"; then exit 0; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this unnecessary since the matrix doesn't have these versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm a bit disappointed in the github api. I should have permission to remove them (they're required actions), but they are not visible to me unless I add them, but even if I remove the requirement later it doesn't fix the issue. It's hacky, but I don't have another solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
add support for entity guid in the health from the health sidecar, listing them in the CR
Type of change
Checklist: