Skip to content

Conversation

@danielstokes
Copy link
Contributor

@danielstokes danielstokes commented Nov 6, 2025

Description

add support for entity guid in the health from the health sidecar, listing them in the CR

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@danielstokes danielstokes requested a review from a team as a code owner November 6, 2025 22:06
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 71.55963% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.51%. Comparing base (6a9d2bf) to head (97754e8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/v1beta3/instrumentation_webhook.go 43.63% 40 Missing and 22 partials ⚠️
cmd/main.go 55.17% 36 Missing and 3 partials ⚠️
api/v1beta3/image_selector.go 71.42% 4 Missing and 4 partials ⚠️
api/v1beta3/name_selector.go 71.42% 4 Missing and 4 partials ⚠️
api/v1beta3/env_selector.go 75.00% 3 Missing and 3 partials ⚠️
internal/instrumentation/health.go 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   69.64%   68.51%   -1.14%     
==========================================
  Files          46       53       +7     
  Lines        2840     3398     +558     
==========================================
+ Hits         1978     2328     +350     
- Misses        695      850     +155     
- Partials      167      220      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


- name: Download minikube
run: |
if test "${{ matrix.k8sVersion }}" == "v1.33.4" || test "${{ matrix.k8sVersion }}" == "v1.32.8" || test "${{ matrix.k8sVersion }}" == "v1.31.12" || test "${{ matrix.k8sVersion }}" == "v1.29.15"; then exit 0; fi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this unnecessary since the matrix doesn't have these versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I'm a bit disappointed in the github api. I should have permission to remove them (they're required actions), but they are not visible to me unless I add them, but even if I remove the requirement later it doesn't fix the issue. It's hacky, but I don't have another solution.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried through the UI? I can show you how to change the required ones.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants