Skip to content

Conversation

@chernetskyi
Copy link
Contributor

@chernetskyi chernetskyi commented Nov 13, 2025

Description

Tolerations set via global.tolerations in nri-bundle did not propagate to the Jobs created by this chart.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@chernetskyi chernetskyi requested a review from a team as a code owner November 13, 2025 10:36
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2025

CLA assistant check
All committers have signed the CLA.

@dbudziwojskiNR
Copy link
Contributor

Hi @chernetskyi, Thank you for your PR! To merge this PR, we're going to need additional unit tests added that cover the new functionality. You can find details on the library we use here. Thank you!

Signed-off-by: Volodymyr Chernetskyi <[email protected]>
Signed-off-by: Volodymyr Chernetskyi <[email protected]>
@chernetskyi
Copy link
Contributor Author

Hello @dbudziwojskiNR,
I've added the unit test and changelog entry. Please review.

Unrelated: the relative link to the contributing guide in the PR template does not work from the PRs.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.93%. Comparing base (ec69bfe) to head (8162ce1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   51.93%   51.93%           
=======================================
  Files           3        3           
  Lines         233      233           
=======================================
  Hits          121      121           
  Misses        107      107           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbudziwojskiNR dbudziwojskiNR changed the title fix: Propagate global tolerations to webhook jobs feat: Propagate global tolerations to webhook jobs Nov 21, 2025
@dbudziwojskiNR
Copy link
Contributor

Hi @chernetskyi! Perfect, merging in. Thanks for catching that broken link, I've fixed that as well. Thank you!

@dbudziwojskiNR dbudziwojskiNR merged commit 7c62688 into newrelic:main Nov 21, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants