-
Notifications
You must be signed in to change notification settings - Fork 19
feat: Propagate global tolerations to webhook jobs #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @chernetskyi, Thank you for your PR! To merge this PR, we're going to need additional unit tests added that cover the new functionality. You can find details on the library we use here. Thank you! |
Signed-off-by: Volodymyr Chernetskyi <[email protected]>
Signed-off-by: Volodymyr Chernetskyi <[email protected]>
|
Hello @dbudziwojskiNR, Unrelated: the relative link to the contributing guide in the PR template does not work from the PRs. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
=======================================
Coverage 51.93% 51.93%
=======================================
Files 3 3
Lines 233 233
=======================================
Hits 121 121
Misses 107 107
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # CHANGELOG.md
|
Hi @chernetskyi! Perfect, merging in. Thanks for catching that broken link, I've fixed that as well. Thank you! |
Description
Tolerations set via
global.tolerationsinnri-bundledid not propagate to the Jobs created by this chart.Type of change
Checklist: