Skip to content

Fix inconsistencies around harvest limit config settings#1737

Draft
hmstepanek wants to merge 4 commits into
mainfrom
fix-serverside-ml-event-order
Draft

Fix inconsistencies around harvest limit config settings#1737
hmstepanek wants to merge 4 commits into
mainfrom
fix-serverside-ml-event-order

Conversation

@hmstepanek
Copy link
Copy Markdown
Contributor

Overview

  • Fix serverside ml_event harvest limits ordering issue.
    • Previously the ml_event would not be added to the allow list which would reject ml_events from being recorded.
  • Remove logging an error message when we attempt to delete a setting on the settings object that doesn't exist.
  • Only report non-deprecated harvest limit setting names in log.

Previously an error message would be logged if we tried to delete a setting that didn't
exist. Instead, check if the setting exists before deleteing to avoid logging a confusing
error message.
@hmstepanek hmstepanek changed the title Fix serverside ml event order Fix inconsistencies around harvest limit config settings May 20, 2026
@github-actions
Copy link
Copy Markdown

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 8 0 0 0.91s
✅ MARKDOWN markdownlint 7 0 0 0 1.37s
✅ PYTHON ruff 1035 1 0 0 1.04s
✅ PYTHON ruff-format 1035 2 0 0 0.39s
✅ YAML prettier 19 0 0 0 1.6s
✅ YAML v8r 19 0 0 4.96s
✅ YAML yamllint 19 0 0 0.69s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant