test: Undici proxy tests #3449
Draft
test: Undici proxy tests #3449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3449 +/- ##
==========================================
- Coverage 97.75% 97.62% -0.13%
==========================================
Files 405 405
Lines 54698 54698
Branches 1 1
==========================================
- Hits 53469 53398 -71
- Misses 1229 1300 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsumners-nr
approved these changes
Oct 22, 2025
bizob2828
requested changes
Oct 23, 2025
Member
bizob2828
left a comment
bizob2828
left a comment
There was a problem hiding this comment.
This wasn't an issue with invalid urls. It was that they were using proxies which put the proxied
URL as path. I don't see any code changes to handle that. Let's sync up on this
Member
|
pausing on this until we can properly replicate a customer issue we observed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer attempted to use traditional
httpproxying withundiciwhich resulted in anInvalidURLerror being thrown. This is the intended behavior because undici doesn't support proxying by suppling a full url to itspathargument inrequest/fetch. These tests verify that bad urls error correctly and that correct undici proxying works as expected.