Repository navigation
Conversation
Use viewport-fixed positioning and ComfyUI-Custom-Scripts caret math, keep the caret mirror off-screen, and scroll suggestion lists in-panel only so long prompts no longer push the page or pin tags at the bottom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long prompts + caret near the bottom made the suggestion list show up at the bottom of the screen and sometimes scroll the whole page.
This change:
Builds on the idea in #74 but that PR only flips the scrollTop sign; this also fixes list highlight scrolling and document height from the mirror div.
Test plan