Add DBSCAN clustering step to Sophronia city#951
Open
camacortespar wants to merge 9 commits intonext-exp:masterfrom
Open
Add DBSCAN clustering step to Sophronia city#951camacortespar wants to merge 9 commits intonext-exp:masterfrom
camacortespar wants to merge 9 commits intonext-exp:masterfrom
Conversation
…esult test is updated to match the new implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates a hit clustering step (using DBSCAN) into the
Sophroniacity workflow.Key Changes
1. New Logic (
reco/hits_functions.py)cluster_tagger: A function that applies DBSCAN on an event-by-event basis.scale_xyandscale_zparameters.2. Integration (
cities/sophronia.py)clustering_paramsto the city configuration.clustering_paramsisNone(default), the city skips clustering and produces the exact same output structure as before (noclustercolumn).3. Testing (
cities/sophronia_test.py&reco/hits_functions_test.py)clustercolumn appears only when enabled.4. Reference Update
database/test_data/228Th_10evt_hits.h5.masterlogic to ensuretest_sophronia_exact_resultpasses with the new code structure.Configuration Example
To use this feature, add the following to the configuration file (these values are optimized for NEXT-100 detector geometry):