lotto - step3 #4172
Merged
lotto - step3 #4172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyoungchoi95
approved these changes
Apr 8, 2025
|
|
||
| import java.util.Objects; | ||
|
|
||
| public class LottoNumber { |
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| public enum Rank { |
| THIRD(Arrays.asList(5), 1_500_000, false), | ||
| FOURTH(Arrays.asList(4), 50_000, false), | ||
| FIFTH(Arrays.asList(3), 5_000, false), | ||
| MISS(Arrays.asList(0, 1, 2), 0, false); |
Comment on lines
+41
to
+53
| if (countOfMatch > 6) { | ||
| throw new IllegalArgumentException("일치하는 번호는 최대 6개까지만 가능합니다."); | ||
| } | ||
|
|
||
| if (countOfMatch == 5) { | ||
| return matchBonus ? SECOND : THIRD; | ||
| } | ||
|
|
||
| return Arrays.stream(values()) | ||
| .filter(rank -> rank.matchCounts.contains(countOfMatch)) | ||
| .findFirst() | ||
| .orElse(MISS); | ||
| } |
There was a problem hiding this comment.
stream 한번으로 모두 처리할 수 있어보여요!
- matchCounts가 포함되는 경우 필터링
- bonus가 일치하는 경우 필터링
- 모두 아니면 예외처리
| if (numbers.size() != LOTTO_SIZE) { | ||
| throw new IllegalArgumentException("로또 번호는 6개여야 합니다."); | ||
| } | ||
| public static Lotto of(List<Integer> numbers) { |
There was a problem hiding this comment.
정적 팩토리 메서드의 경우 관습적으로 파라메터가 1개인 경우 from을 사용합니다. 파라메터가 여러개일 때 of를 사용하여요.
영문표현과 연관있는 관습이라고 봐주시면 좋을 것 같네요 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
감사합니다.