[stable8] feat(NcAppSettingsDialog): new navigation design#8503
Merged
[stable8] feat(NcAppSettingsDialog): new navigation design#8503
Conversation
nfebe
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable8 #8503 +/- ##
===========================================
+ Coverage 46.84% 46.85% +0.01%
===========================================
Files 195 195
Lines 4921 4926 +5
Branches 1268 1268
===========================================
+ Hits 2305 2308 +3
- Misses 2528 2529 +1
- Partials 88 89 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nfebe
force-pushed
the
backport/align-settings-title/stable8
branch
2 times, most recently
from
913e77c to
57bcbb3
Compare
ShGKme
changed the title
ShGKme
previously requested changes
May 7, 2026
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
In the main the merged version used the new navigation design on older server versions.
In this PR, the navigation design is always new
main on v32 |
This PR on v32 |
|---|---|
 |
 |
On legacy settings format (:legacy="true" - default) there is no title on any version
| v34 | v32 |
|---|---|
 |
 |
On the new settings format (:legacy="false"):
- No title on v32
- Settings content has legacy styles applied even though the prop says to use the new format
| v34 | v32 |
|---|---|
 |
 |
ShGKme
added
enhancement
nfebe
force-pushed
the
backport/align-settings-title/stable8
branch
2 times, most recently
from
74033ad to
9753ddf
Compare
sorbaugh
approved these changes
May 7, 2026
The settings dialog title now sits over a tinted navigation column on the inline-start edge of the dialog, replacing the centered header. Navigation links use the default button weight with a rounded inline-start stripe on the active item. Backport of the v9 main change to stable8. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
backport/align-settings-title/stable8
branch
from
9753ddf to
d401cbd
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings dialog title now sits over a tinted navigation column on the inline-start edge of the dialog, replacing the centered header. Navigation links use the default button weight with a rounded inline-start stripe on the active item.
Backport of #8477