Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish confirmation modal #10101

Open
kesselb opened this issue Sep 4, 2024 · 4 comments · May be fixed by #10924
Open

Polish confirmation modal #10101

kesselb opened this issue Sep 4, 2024 · 4 comments · May be fixed by #10924

Comments

@kesselb
Copy link
Contributor

kesselb commented Sep 4, 2024

Steps to reproduce

  1. Select a message
  2. Pick edit tags
  3. Delete a tag

Expected behavior

The modal looks a bit unfinished.
For example there's a lot of padding to the top but no spacing to the action items.

Actual behavior

image

Mail app version

629a9fa

Mailserver or service

No response

Operating system

No response

PHP engine version

None

Web server

None

Database

None

Additional info

No response

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2024

I think we can replace our confirmation modal with https://nextcloud-vue-components.netlify.app/#/Components/NcDialog

@keremsemiz
Copy link
Contributor

How does this revision look?
Image

@GretaD
Copy link
Contributor

GretaD commented Mar 25, 2025

How does this revision look? Image

it looks very good. I see a border on top of buttons, if that was added by you, you should remove it because as per design we dont have border above the buttons. Otherwise that looks great so please send a pull request and add me as reviewer

@keremsemiz
Copy link
Contributor

ok perfect, thanks, yeah i added the border, will remove it and pull.

keremsemiz added a commit that referenced this issue Mar 25, 2025
Styling fixes to confirmation modal.
@GretaD GretaD linked a pull request Mar 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants