fix: delete tag modal #10924
fix: delete tag modal #10924
Conversation
Styling fixes to confirmation modal.
keremsemiz
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
src/components/ConfirmationModal.vue
Outdated
| margin-bottom: 20px; | ||
| font-size: 24px; | ||
| font-weight: 600; | ||
| } |
There was a problem hiding this comment.
you dont need this part, the buttons inherits the styling from nc/vue library and it should stay that way, so it looks the same everywhere
src/components/ConfirmationModal.vue
Outdated
| margin-top: 30px; | ||
| padding-top: 20px; | ||
|
|
||
| :deep(button) { |
There was a problem hiding this comment.
also, you dont need the v:deep. You only need to add space on top of the buttons, and you need to make sure the buttons have space in between.
src/components/ConfirmationModal.vue
Outdated
| gap: 16px; | ||
| margin-top: 30px; | ||
| padding-top: 20px; | ||
|
|
There was a problem hiding this comment.
this part is correct, you want to add either a margin or a padding, not both as they both add space.
The buttons should have space between so they are aligned left and right. So keep that as it is.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
fixes #10101
Styling fixes to confirmation modal.