-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: PR Checklist #10891
Open
SebastianKrupinski
wants to merge
1
commit into
main
Choose a base branch
from
chore/pr-tempalate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: PR Checklist #10891
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
|
||
## ☑️ Overview | ||
|
||
* Requires: #… | ||
* Resolves: #… | ||
|
||
* Backport to… | ||
|
||
### Summary | ||
|
||
Please give a brief summary of the changes | ||
|
||
### Testing | ||
|
||
Please give a brief explanation of how to test | ||
|
||
1. ... | ||
2. ... | ||
3. ... | ||
|
||
|
||
<!-- | ||
Feel free to remove this section if your PR does not make any changes to the UI | ||
--> | ||
|
||
--- | ||
|
||
## 🖌️ Front End Checklist | ||
|
||
### Summary | ||
|
||
Please give a brief summary of the front end changes | ||
|
||
### 🖼️ Screenshots / Screencasts | ||
|
||
🏚️ Before | 🏡 After | ||
-- | -- | ||
Screenshot before | Screenshot after | ||
|
||
<!-- ☀️ Light theme | 🌑 Dark Theme --> | ||
|
||
### 🚧 Tasks | ||
|
||
- [ ] ... | ||
|
||
### 🏁 Checklist | ||
|
||
| ❌ | ✅ | Task | | ||
|----|----|-----| | ||
| [ ] | [ ] | 🌏 Tested with different browsers / clients: | ||
| | [ ] | Chromium (Chrome / Edge / Opera / Brave) | ||
| | [ ] | Firefox | ||
| | [ ] | Safari | ||
| | [ ] | Not risky to browser differences / client | ||
| [ ] | [ ] | 🖌️ Design was reviewed, approved or inspired by the design team | ||
| [ ] | [ ] | ⛑️ Tests (unit and/or integration) | ||
| [ ] | [ ] | 📗 Admin documentation in https://github.com/nextcloud/documentation/tree/master/admin_manual/groupware | ||
| [ ] | [ ] | 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/groupware | ||
|
||
<!-- | ||
Feel free to remove this section when your PR is only touching frontend/UI code | ||
--> | ||
|
||
--- | ||
|
||
## 🛠️ Back End Checklist | ||
|
||
### Summary | ||
|
||
Please give a brief summary of the back end changes | ||
|
||
### 🚧 Tasks | ||
|
||
- [ ] ... | ||
|
||
### 🏁 Checklist | ||
|
||
| ❌ | ✅ | Task | | ||
|----|----|-----| | ||
| [ ] | [ ] | ⛑️ Tests (unit and/or integration) | ||
| [ ] | [ ] | 📗 Admin documentation in https://github.com/nextcloud/documentation/tree/master/admin_manual/groupware | ||
| [ ] | [ ] | 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/groupware | ||
| [ ] | [ ] | 📘 Developer documentation in https://github.com/nextcloud/documentation/tree/master/developer_manual | ||
Comment on lines
+28
to
+83
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMO this is asking too much, which will tend to make people ignore the template |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors | ||
# SPDX-License-Identifier: AGPL-3.0-or-later |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be done in comments anyway -> duplicates information -> drop it