Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: PR Checklist #10891

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@

## ☑️ Overview

* Requires: #…
* Resolves: #…

* Backport to…
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be done in comments anyway -> duplicates information -> drop it


### Summary

Please give a brief summary of the changes

### Testing

Please give a brief explanation of how to test

1. ...
2. ...
3. ...


<!--
Feel free to remove this section if your PR does not make any changes to the UI
-->

---

## 🖌️ Front End Checklist

### Summary

Please give a brief summary of the front end changes

### 🖼️ Screenshots / Screencasts

🏚️ Before | 🏡 After
-- | --
Screenshot before | Screenshot after

<!-- ☀️ Light theme | 🌑 Dark Theme -->

### 🚧 Tasks

- [ ] ...

### 🏁 Checklist

| ❌ | ✅ | Task |
|----|----|-----|
| [ ] | [ ] | 🌏 Tested with different browsers / clients:
| | [ ] | Chromium (Chrome / Edge / Opera / Brave)
| | [ ] | Firefox
| | [ ] | Safari
| | [ ] | Not risky to browser differences / client
| [ ] | [ ] | 🖌️ Design was reviewed, approved or inspired by the design team
| [ ] | [ ] | ⛑️ Tests (unit and/or integration)
| [ ] | [ ] | 📗 Admin documentation in https://github.com/nextcloud/documentation/tree/master/admin_manual/groupware
| [ ] | [ ] | 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/groupware

<!--
Feel free to remove this section when your PR is only touching frontend/UI code
-->

---

## 🛠️ Back End Checklist

### Summary

Please give a brief summary of the back end changes

### 🚧 Tasks

- [ ] ...

### 🏁 Checklist

| ❌ | ✅ | Task |
|----|----|-----|
| [ ] | [ ] | ⛑️ Tests (unit and/or integration)
| [ ] | [ ] | 📗 Admin documentation in https://github.com/nextcloud/documentation/tree/master/admin_manual/groupware
| [ ] | [ ] | 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/groupware
| [ ] | [ ] | 📘 Developer documentation in https://github.com/nextcloud/documentation/tree/master/developer_manual
Comment on lines +28 to +83
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is asking too much, which will tend to make people ignore the template

2 changes: 2 additions & 0 deletions .github/pull_request_template.md.license
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later