fix: show submailboxes for filtering #11031
Conversation
| @@ -92,6 +92,7 @@ export default { | |||
| input.vue-treeselect__input { | |||
| margin: 0; | |||
| padding: 0; | |||
| border: 1px solid var(--color-border-maxcontrast) !important; | |||
There was a problem hiding this comment.
What makes this necessary?
There was a problem hiding this comment.
treeselect borders are 2px by default. Ours are 1px.
| return this.currentSelectedMailboxId | ||
| }, | ||
| set(selectedMailboxId) { | ||
| logger.debug('Selected mailbox set to', selectedMailboxId) |
There was a problem hiding this comment.
i added this because thats what we do on accountdefaultsettings.vue where we also use the MailboxInlinePicker.
GretaD
force-pushed
the
fix/filter-subfolders
branch
from
f4c50e0 to
a5a7df8
Compare
|
Hi Greta, Thanks again for your help on this. I apologize; I completely forgot that this is a nightmare 😂 The MailboxInlinePicker uses the databaseId, while the Sieve backend expects the IMAP name. I believe this was the reason I initially opted for the simple NcSelect to avoid the back-and-forth. I apparently overlooked the fact that getMailboxes surprisingly does not return "submailboxes." I've pushed a fix to resolve the databaseId to the IMAP name and vice versa. |
|
The border looks a bit odd in dark mode 😞 |
we can fix that with other design issues that Nimisha has added in the overview ticket #10655 |
|
Fix it here so we have a releasable solution after merge into main. |
|
the second box is slightly bigger and i cannot change that
|
|
Hi @GretaD, I'm still seeing that weird border 😞 It appears that p from the help-text is overflowing and then overlapping with the treeselect. What do you think about adding .help-text {
margin-bottom: calc(var(--default-grid-baseline) * 2);
}to UpdateModal.vue as a workaround? |
Signed-off-by: greta <[email protected]>
kesselb
force-pushed
the
fix/filter-subfolders
branch
from
0633c81 to
4874ee4
Compare
|
/backport to stable5.0 |
Fix #10545