fix(files_sharing): Hide 'Open locally' action #56060
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
the
4. to release
skjnldsv
requested review from
artonge,
sorbaugh and
szaimen
and removed request for
a team
Member
Author
|
/compile |
This patch ensures that the "Open locally" context menu item is not displayed for files in a share where the "download and sync" permission has not been granted. This prevents user confusion, as the action would fail anyway. The fix adds a permission check before rendering the menu item, and adds a corresponding unit test to verify this behavior. Resolves: #54970 Signed-off-by: Fauzan <[email protected]>
skjnldsv
force-pushed
the
fix/hide-open-locally-action
branch
from
35b709b to
096047a
Compare
7 tasks
susnux
reviewed
Oct 28, 2025
| } | ||
|
|
||
| return true | ||
| } |
Signed-off-by: nextcloud-command <[email protected]>
susnux
reviewed
Oct 28, 2025
Comment on lines
+52
to
+66
| // check hide-download property of shares | ||
| if (node.attributes['hide-download'] === true | ||
| || node.attributes['hide-download'] === 'true' | ||
| ) { | ||
| return false | ||
| } | ||
|
|
||
| // If the mount type is a share, ensure it got download permissions. | ||
| if (node.attributes['share-attributes']) { | ||
| const shareAttributes = JSON.parse(node.attributes['share-attributes'] || '[]') as Array<ShareAttribute> | ||
| const downloadAttribute = shareAttributes.find(({ scope, key }: ShareAttribute) => scope === 'permissions' && key === 'download') | ||
| if (downloadAttribute !== undefined) { | ||
| return downloadAttribute.value === true | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Isnt this basically
Suggested change
| // check hide-download property of shares | |
| if (node.attributes['hide-download'] === true | |
| || node.attributes['hide-download'] === 'true' | |
| ) { | |
| return false | |
| } | |
| // If the mount type is a share, ensure it got download permissions. | |
| if (node.attributes['share-attributes']) { | |
| const shareAttributes = JSON.parse(node.attributes['share-attributes'] || '[]') as Array<ShareAttribute> | |
| const downloadAttribute = shareAttributes.find(({ scope, key }: ShareAttribute) => scope === 'permissions' && key === 'download') | |
| if (downloadAttribute !== undefined) { | |
| return downloadAttribute.value === true | |
| } | |
| } | |
| if (!isDownloadable(node)) { | |
| return false | |
| } |
There was a problem hiding this comment.
Allow me to jump into the discussion. Yes, it’s basically the same logic as the isDownloadable function. I just copied and pasted the logic. But doesn’t your suggestion make the node.permissions validation repetitive? It already checks the UPDATE permission, which means it automatically has READ permission.
Member
Author
There was a problem hiding this comment.
It already checks the UPDATE permission, which means it automatically has READ permission
you could have UPDATE without READ per se :)
There was a problem hiding this comment.
my bad:), should i update it first? re-commit to my fork?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual push of #55992 from community
Closes #55992