Skip to content

Fix #57282: icon color mismatch on download button in public share #59175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodrigocorreiaist wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −1
Open

Fix #57282: icon color mismatch on download button in public share #59175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion core/src/views/PublicPageMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,23 @@ function openDialogIfNeeded() {
}

&__primary-icon {
filter: var(--primary-invert-if-bright);
// Light mode: icon is black by default, invert to white when primary is dark
filter: var(--primary-invert-if-dark);

// Dark mode: icon is white (swapped in icons.css), invert to black when primary is bright
@media (prefers-color-scheme: dark) {
filter: var(--primary-invert-if-bright);
}
}
}

// Dark theme via Nextcloud setting (data-themes attribute, not media query)
:global([data-themes*=dark]) .public-page-menu__primary-icon {
filter: var(--primary-invert-if-bright);
}

// Light theme explicitly set (overrides dark media query if system is dark but user chose light)
:global([data-themes*=light]) .public-page-menu__primary-icon {
filter: var(--primary-invert-if-dark);
}
</style>
Loading