Skip to content

Data Lineage quick fixes #6045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2025
Merged

Data Lineage quick fixes #6045

merged 4 commits into from
May 8, 2025

Conversation

jorgee
Copy link
Contributor

@jorgee jorgee commented May 7, 2025 •
edited
Loading

This PR includes

  • LinHistoryLog was only considering the session id to write the lineage log entry. Now, it also uses the run name.
  • Sort the script files in workflow description to facilitate the diff between executions

@netlify Netlify
Copy link

netlify bot commented May 7, 2025 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 439de1b
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/681cb41b13d37a0009dd8c1d
😎 Deploy Preview https://deploy-preview-6045--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jorgee jorgee requested a review from pditommaso May 7, 2025 12:53
@jorgee
Copy link
Contributor Author

jorgee commented May 8, 2025

Refactor LinHistoryLog:

  • Removed updateRunLid and getRecord (getRecord was only used in tests).
  • DefaultLinHistoryLog uses workflowHash to store the record.

@bentsherman bentsherman added this to the 25.04 milestone May 8, 2025
@pditommaso pditommaso merged commit f3cee76 into master May 8, 2025
22 checks passed
@pditommaso pditommaso deleted the data-lineage-quick-fixes branch May 8, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pditommaso pditommaso pditommaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.04
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgee @pditommaso @bentsherman