-
Notifications
You must be signed in to change notification settings - Fork 688
Solve queueSize exceeded when using job arrays #6047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Ben Sherman <[email protected]>
|
Signed-off-by: Ben Sherman <[email protected]>
@@ -266,7 +273,7 @@ abstract class TaskHandler { | |||
*/ | |||
boolean canForkProcess() { | |||
final max = task.processor.maxForks | |||
return !max ? true : task.processor.forksCount < max | |||
return !max ? true : task.processor.forksCount + getForksCount() <= max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be task.processor.forksCount * getForksCount()
, I mean multiplied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would it be multiplied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I was totally confused by the getForksCount
naming. This new attribute should be named differently because it overlaps with processor.forksCount
that has a complete different meaning. Something like getRunsCount
and getArraySize
would be much better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are they different in meaning?
Signed-off-by: Ben Sherman <[email protected]>
@@ -266,7 +273,7 @@ abstract class TaskHandler { | |||
*/ | |||
boolean canForkProcess() { | |||
final max = task.processor.maxForks | |||
return !max ? true : task.processor.forksCount < max | |||
return !max ? true : task.processor.forksCount + getForksCount() <= max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I was totally confused by the getForksCount
naming. This new attribute should be named differently because it overlaps with processor.forksCount
that has a complete different meaning. Something like getRunsCount
and getArraySize
would be much better
Because |
So "forks" here just refers to the number of concurrent tasks, therefore I see no reason to call it something else in the task handler |
close #5920
executor.queueSize
parameter.Tested with this pipeline
With a config with
awsbatch
executor and differentexecutor.queueSize
values: