Skip to content

DOC: Fix selector expression documentation #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 9, 2025

Conversation

zeehio
Copy link
Contributor

@zeehio zeehio commented May 7, 2025

This PR makes a minor clarification:

Given the syntax:

withLabel: 'foo|bar' {
}

It applies to processes with the label foo OR with the label bar. However the description stated that it was applied to processes with label foo AND label bar which was confusing to me.

Thanks!

```
withLabel: 'foo|bar' {
}
```

Is applied to processes with the label foo or with the label bar. However the description stated that it was applied to processes with label foo AND label bar.



Signed-off-by: Sergio Oller <[email protected]>
@zeehio zeehio requested a review from a team as a code owner May 7, 2025 17:35
Copy link

netlify bot commented May 7, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 015811f
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/681df96143b3570008b8f45d

Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a suggestion. I would go with "or" over "and" to keep it inline with the |, but the current suggestion also works.

@bentsherman
Copy link
Member

@pditommaso this PR is ready to merge but for some reason the same google unit tests keeps failing, so I can't merge it

@pditommaso pditommaso merged commit 548c87b into nextflow-io:master May 9, 2025
8 of 10 checks passed
@zeehio
Copy link
Contributor Author

zeehio commented May 10, 2025

Thanks for your review and merge!

@zeehio zeehio deleted the patch-1 branch May 10, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants