Fix hashing of directories #6113
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files.walkFileTree
does not guarantee any specific order for iterating over files within a directory:-- source
This causes the sha of
HashBuilder.hashDirSha256
to be different in certain situations (#6112).This PR fixes the issue by storing all of the (path, sha256) in an array list, sorting by path, and then passing them to the hasher.
Notes:
preVisitDirectory
seems like it would cause a null pointer exception if the condition (base != null
) is false -- so maybebase
is always not null? What should happen in this code chuck if base does happen to be null?