Skip to content

Use Priority to override existing executor #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Lehmann-Fabian
Copy link
Contributor

Since ServiceName.important is deprecated, I added support for the Priority annotation to work with the same behavior as other Nextflow Extension Points.

Copy link

netlify bot commented May 28, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit c7398ee
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/683a22683bb22400085bfc23

@bentsherman bentsherman changed the title Use Priority to (not) overwrite Executor Use Priority to override existing executor May 30, 2025
@bentsherman
Copy link
Member

Plugins.getPriorityExtensions() is normally used to load plugins in a priority-aware manner, and should ideally be used here as well. Though I'm not sure why the plugin manager is provided here instead of just using Plugins

@Lehmann-Fabian
Copy link
Contributor Author

Lehmann-Fabian commented May 30, 2025

I think we can merge both constructors now as the manager isn't used anymore. What do you think?

Signed-off-by: Lehmann_Fabian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants