feat: add native support for TPUs and multi-vendor hardware accelerators#6911
Open
Joon-Klaps wants to merge 5 commits intonextflow-io:masterfrom
Open
feat: add native support for TPUs and multi-vendor hardware accelerators#6911Joon-Klaps wants to merge 5 commits intonextflow-io:masterfrom
Joon-Klaps wants to merge 5 commits intonextflow-io:masterfrom
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Joon-Klaps <joon.klaps@kuleuven.be>
Signed-off-by: Joon-Klaps <joon.klaps@kuleuven.be>
Signed-off-by: Joon-Klaps <joon.klaps@kuleuven.be>
Signed-off-by: Joon-Klaps <joon.klaps@kuleuven.be>
Signed-off-by: Joon-Klaps <joon.klaps@kuleuven.be>
tomiles
approved these changes
Mar 12, 2026
tomiles
left a comment
tomiles
left a comment
There was a problem hiding this comment.
It looks great! I like the idea of adding the .toLowerCase() method to the type definition. 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the PodSpecBuilder to natively support a wider range of hardware accelerators, specifically targeting Google TPUs (GKE), AMD GPUs, AWS Neuron (Inferentia/Trainium), and Intel Gaudi devices. It removes the need for manual pod directive overrides by automatically mapping common hardware shorthands to their correct Kubernetes Extended Resource strings.
Previously, the getAcceleratorType logic was heavily biased toward NVIDIA GPUs (nvidia.com/gpu). If a user requested a TPU or an AMD GPU using shorthand (e.g., accelerator: 'tpu'), the builder would either fail to map it correctly or produce an invalid resource string like tpu.com/gpu. This forced AI/ML practitioners to manually override Pod specs to run workloads on non-NVIDIA hardware.