Fix LogsCheckpoint thread interrupt race condition#6939
Open
pditommaso wants to merge 1 commit intomasterfrom
Open
Fix LogsCheckpoint thread interrupt race condition#6939pditommaso wants to merge 1 commit intomasterfrom
pditommaso wants to merge 1 commit intomasterfrom
Conversation
Check interrupt flag after await() returns and before calling saveFiles(), preventing the AWS SDK from seeing the interrupt flag and throwing AbortedException during S3 uploads at shutdown. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Member
|
I feel like we have iterated on this code a dozen times trying to find the right logic 😅 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogsCheckpoint.run()wheresaveFiles()was called with the thread interrupt flag already set afterawait()caught anInterruptedExceptionAbortedException("Thread was interrupted") during S3 uploads at workflow shutdownawait()returns and beforesaveFiles(), so the loop exits cleanly on shutdownTest plan
AbortedExceptionwarnings in logs when running workflows with Tower/Seqera platform integration and remote work directory🤖 Generated with Claude Code