Open
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
… of 1 min Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially close #6885
This pull request adds support for configurable HTTP request timeouts in the
TowerClientand introduces a corresponding test to ensure correct error handling on timeout. The main changes include introducing a default timeout, allowing custom timeouts per client, applying the timeout to HTTP requests, and testing the timeout behavior.Enhancements to HTTP request timeout handling:
DEFAULT_REQUEST_TIMEOUT(1 min) and arequestTimeoutproperty toTowerClient, with a newwithRequestTimeout(Duration)method to allow per-client timeout configuration. [1] [2] [3]requestTimeoutvalue to all outgoing HTTP requests by setting the timeout on the HTTP request builder.Testing improvements:
TowerClientTestthat uses WireMock to simulate a slow server, verifying that a request with a short timeout fails as expected and returns an error response. [1] [2] [3]