Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown gracefully #1018

Merged
merged 10 commits into from
Apr 7, 2025
Merged

Shutdown gracefully #1018

merged 10 commits into from
Apr 7, 2025
+28 −6

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Mar 25, 2025

Proposed changes

Fixed Issue causing agent to ignore SIGQUIT and not shut down gracefully.
Fixed log for allowed directories

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Mar 25, 2025
@aphralG aphralG requested a review from a team as a code owner March 25, 2025 10:32
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 25, 2025
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Mar 27, 2025
@RRashmit
Copy link
Contributor

RRashmit commented Apr 2, 2025 •
edited
Loading

Verified:
Sent SIGQUIT
kill -QUIT <PID>
Container
image
VM
image

@aphralG aphralG merged commit 55b81f4 into v3 Apr 7, 2025
20 checks passed
@aphralG aphralG deleted the shutdown-gracefully branch April 7, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@sean-breen sean-breen sean-breen approved these changes

@RRashmit RRashmit RRashmit approved these changes

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aphralG @RRashmit @dhurley @sean-breen @oCHRISo