[Dev] Add a run directory when developing locally#1398
Merged
sean-breen merged 6 commits intomainfrom Dec 11, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
+ Coverage 85.19% 85.31% +0.11%
==========================================
Files 102 102
Lines 12972 12972
==========================================
+ Hits 11052 11067 +15
+ Misses 1435 1418 -17
- Partials 485 487 +2 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dhurley
reviewed
Nov 21, 2025
dhurley
approved these changes
Nov 21, 2025
spencerugbo
approved these changes
Nov 21, 2025
craigell
approved these changes
Nov 25, 2025
aphralG
approved these changes
Dec 3, 2025
Akshay2191
pushed a commit
that referenced
this pull request
Dec 18, 2025
* creates a run directory under build to use when developing locally * add back missing target * add back external file server to mock management target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change modifies the Makefile to create a
build/rundirectory when running themake devtarget, with the goal of making local development of the agent a little easier by keeping all of our runtime files in an easy to access location.This directory must be added to the
allowed_directoriesinnginx-agent.confbefore runningmake dev.This directory will contain several files which we create at runtime:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)