Refactor agent logging

[dhurley]

Proposed changes

• Refactor what gets logged when log level is set to info.
• Add RequestType to DataPlaneResponse proto message.
• Log health requests as debug instead of info.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING document
• I have run make install-tools and have attached any dependency changes to this pull request
• If applicable, I have added tests that prove my fix is effective or that my feature works
• If applicable, I have checked that any relevant tests pass after adding my changes
• If applicable, I have updated any relevant documentation (README.md)
• If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

[codecov]

Codecov Report

❌ Patch coverage is 82.38213% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.18%. Comparing base (6cbcd8b) to head (8c124c2).
⚠️ Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/command/command_plugin.go	31.25%	21 Missing and 1 partial ⚠️
internal/bus/message_pipe.go	0.00%	15 Missing ⚠️
internal/resource/resource_service.go	0.00%	9 Missing ⚠️
...ernal/watcher/instance/instance_watcher_service.go	10.00%	8 Missing and 1 partial ⚠️
internal/grpc/grpc.go	16.66%	5 Missing ⚠️
internal/collector/otel_collector_plugin.go	80.95%	2 Missing and 2 partials ⚠️
internal/file/file_plugin.go	90.00%	2 Missing ⚠️
internal/plugin/plugin_manager.go	83.33%	2 Missing ⚠️
internal/resource/nginx_plus_actions.go	98.63%	2 Missing ⚠️
internal/file/file_manager_service.go	93.75%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
+ Coverage   85.15%   85.18%   +0.02%     
==========================================
  Files         102      102              
  Lines       12984    13209     +225     
==========================================
+ Hits        11057    11252     +195     
- Misses       1440     1467      +27     
- Partials      487      490       +3     

Files with missing lines	Coverage Δ
internal/collector/settings.go	77.14% <100.00%> (ø)
internal/command/command_service.go	79.82% <100.00%> (ø)
internal/datasource/proto/response.go	100.00% <100.00%> (ø)
internal/file/file_service_operator.go	76.82% <100.00%> (+0.52%)	⬆️
internal/resource/nginx_instance_operator.go	91.17% <100.00%> (+0.08%)	⬆️
internal/resource/resource_plugin.go	79.57% <100.00%> (+6.39%)	⬆️
internal/watcher/file/file_watcher_service.go	81.29% <100.00%> (+1.93%)	⬆️
internal/watcher/health/health_watcher_service.go	89.09% <100.00%> (+3.10%)	⬆️
internal/watcher/instance/nginx_process_parser.go	91.04% <ø> (-0.63%)	⬇️
internal/watcher/watcher_plugin.go	72.91% <100.00%> (+1.04%)	⬆️
... and 10 more

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbcd8b...8c124c2. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[aphralG]

Could we add more logging around the file actions and the manifest file ?

[aphralG]

Can we add a log for updating and adding for consistency ?

[dhurley]

The RenameFile function is already logging that

[aphralG]

Ok, just not sure renaming makes it clear that the file is being updated or added the way that its clear a file is being deleted. I wouldn't be able to tell immediately the action being preformed

[aphralG]

Could the type also be logged, auxiliary or command ?

[dhurley]

Yeah I'll add the server type to the context so that it gets logged here