Conversation
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
==========================================
- Coverage 85.02% 84.92% -0.10%
==========================================
Files 103 103
Lines 13589 13601 +12
==========================================
- Hits 11554 11551 -3
- Misses 1518 1535 +17
+ Partials 517 515 -2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I have hereby read the F5 CLA and agree to its terms. |
vivki
force-pushed
the
vxu-agent
branch
2 times, most recently
from
7b3317d to
f00237a
Compare
|
recheck |
vivki
force-pushed
the
vxu-agent
branch
2 times, most recently
from
d5f9118 to
174dcf7
Compare
|
I have hereby read the F5 CLA and agree to its terms |
|
recheck |
vivki
force-pushed
the
vxu-agent
branch
2 times, most recently
from
e1c4663 to
e9c746e
Compare
| # Use PR head branch (the feature branch) when running from a pull_request event. | ||
| # Fallback to github.head_ref (sanity) or ref name for other contexts. | ||
| target-branch: ${{ github.event.pull_request.head.ref || github.head_ref || github.ref_name }} | ||
| # Use PR head SHA for pull requests (supports PRs from forks). |
There was a problem hiding this comment.
I'm not familiar with this repos workflows, so maybe someone from the agent team can take a look and see why this is necessary
vivki
force-pushed
the
vxu-agent
branch
2 times, most recently
from
05ea69e to
4948cf3
Compare
Use commit SHA instead of branch name when checking out PR code. This fixes the checkout error for PRs from forks where the branch doesn't exist in the upstream repository.
vivki
changed the title
2 participants
Proposed changes
This PR adds logs for external file downloads. These are needed on the NGINXaaS side to generate events.
Agent V3 currently does log errors caused by failed file downloads, e.g.
apply error: failed to download file /etc/nginx/mycert.cert from projects/900024435491/secrets/valyria-secret/versions/latest: download failed with status code 401: no workload identity pool provider specifiedWith this current change, any download errors will also be logged with a standard failure message to be parsed by NGINXaaS:
2026-04-01T10:15:32.123Z ERROR Failed to download external file event_tag=ID-1310 location=http://naasproxy:49152/google_secret_manager/projects%2F219735614622%2Fsecrets%2Fvxu-key%2Fversions%2F1 err="connection timed out"Additionally, a success log is added, to be parsed by NGINXaaS:
2026-04-01T10:15:33.456Z INFO Successfully downloaded external file event_tag=ID-1310 location=http://naasproxy:49152/google_secret_manager/projects%2F219735614622%2Fsecrets%2Fvxu-key%2Fversions%2F1 hash=a3f5b8c9d2e1f4a7b6c5d8e9f1a2b3c4d5e6f7a8b9c0d1e2f3a4b5c6d7e8f9a0No existing logs have been changed.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)