-
Notifications
You must be signed in to change notification settings - Fork 132
Update NodePort and Helm Chart configuration in get-started.md #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update NodePort and Helm Chart configuration in get-started.md #1629
Conversation
Added the nodePort 30478 and the containerPort 8443. This is needed because the tutorial fails on the part of HTTPS Termination since the Kind Cluster does not have the needed ports exposed.
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
I have hereby read the F5 CLA and agree to its terms |
| - containerPort: 31437 | ||
| hostPort: 8080 | ||
| protocol: TCP | ||
| - containerPort:30478 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - containerPort:30478 | |
| - containerPort: 30478 |
|
There is no HTTPS as part of this tutorial guide. @pedroignacio13 Are you using this guide as the setup for the other guides we have? @ADubhlaoich not sure we considered that scenario, since our other traffic guides don't use the "Get Started" guide as a prerequisite. How should we approach that? |
|
@sjberman in this file (get-started.md) it really does not have any HTTPS reference, but if you go to the HTTPS Termination page of the tutorial (https://docs.nginx.com/nginx-gateway-fabric/traffic-management/https-termination/) that's when it starts having some trouble. |
I guess if the get started guide is being used an example, it's good to show how to enable HTTPS, but the actual design intent for the document is just to show a test cluster deployment quickly, on the basis that someone would follow a dedicated "full" deployment guide for a production environment. If it doesn't "break" this guide I see no harm in adding the scope of the PR's changes. @pedroignacio13 Are you following through documentation starting from Get started for a production environment, or just testing? There's a big notice box at the very top of "Get started" directing users to other deployment guides: I' m trying to understand if that was effective or not.
|

Added the nodePort 30478 and the containerPort 8443. This is needed because the tutorial fails on the part of HTTPS Termination since the Kind Cluster does not have the needed ports exposed.
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩