Skip to content

Add control-id label to Agent as required for N1C #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented May 28, 2025

Proposed changes

For NIC, this label is the same as installation-id but is required for use for N1C integration.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner May 28, 2025 15:23
@github-actions github-actions bot added the go Pull requests that update Go code label May 28, 2025
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.48%. Comparing base (07c302f) to head (0814d37).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/nginx/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7849   +/-   ##
=======================================
  Coverage   52.47%   52.48%           
=======================================
  Files          90       90           
  Lines       21549    21550    +1     
=======================================
+ Hits        11308    11310    +2     
+ Misses       9772     9771    -1     
  Partials      469      469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexFenlon AlexFenlon enabled auto-merge (squash) May 30, 2025 08:49
@AlexFenlon AlexFenlon merged commit b422a76 into main May 30, 2025
84 checks passed
@AlexFenlon AlexFenlon deleted the add-control-id-to-agent-labels branch May 30, 2025 12:09
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 🚀 in NGINX Ingress Controller May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants