-
Notifications
You must be signed in to change notification settings - Fork 114
CP/DP Update non-functional tests #3305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP/DP Update non-functional tests #3305
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3305 +/- ##
===================================================================
- Coverage 89.74% 86.68% -3.06%
===================================================================
Files 109 125 +16
Lines 11150 14447 +3297
Branches 50 62 +12
===================================================================
+ Hits 10007 12524 +2517
- Misses 1083 1785 +702
- Partials 60 138 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Will post a picture of the updated longevity dashboard soon. |
Created #3311 to track enabling upgrade nfr test for 2.1 release. |
Here is what the longevity dashboard looks like now, notably we are missing all of the nginx specific metrics. We now only have access the container cpu and memory. Added an additional possible acceptance criteria to #1744 which describes why and would we could do to recover more graphs. |
Functional tests do not pass, but the fix should come in when #3275 is merged where another volume is added for agent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I'm assuming all the results look as expected with the changes?
Yep, i don't know if the automated github workflow will work, but manually running works and the results look as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
580823a
to
627a31a
Compare
627a31a
to
05672e5
Compare
Update non-functional tests for the control plane data plane split. Problem: The non-functional tests do not work for the control plane data plane split changes. Solution: Update non-functional tests. Testing: Scale, Reconfiguration, Performance, and Longevity tests work. Upgrade test doesn't work, however that is sort of planned since the CP/DP split is a breaking change of NGF and thus you can't easily upgrade with zero downtime. --------- Co-authored-by: Saylor Berman <[email protected]>
Proposed changes
Update non-functional tests for the control plane data plane split.
Problem: The non-functional tests do not work for the control plane data plane split changes.
Solution: Update non-functional tests.
Testing: Scale, Reconfiguration, Performance, and Longevity tests work. Upgrade test doesn't work, however that is sort of planned since the CP/DP split is a breaking change of NGF and thus you can't easily upgrade with zero downtime.
Closes #3010
#2374
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.