Skip to content

CP/DP Update non-functional tests #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Apr 17, 2025

Proposed changes

Update non-functional tests for the control plane data plane split.

Problem: The non-functional tests do not work for the control plane data plane split changes.

Solution: Update non-functional tests.

Testing: Scale, Reconfiguration, Performance, and Longevity tests work. Upgrade test doesn't work, however that is sort of planned since the CP/DP split is a breaking change of NGF and thus you can't easily upgrade with zero downtime.

Closes #3010
#2374

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added tests Pull requests that update tests helm-chart Relates to helm chart labels Apr 17, 2025
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (6337c97) to head (6736cc8).
Report is 187 commits behind head on change/control-data-plane-split.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3305      +/-   ##
===================================================================
- Coverage                            89.74%   86.68%   -3.06%     
===================================================================
  Files                                  109      125      +16     
  Lines                                11150    14447    +3297     
  Branches                                50       62      +12     
===================================================================
+ Hits                                 10007    12524    +2517     
- Misses                                1083     1785     +702     
- Partials                                60      138      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19
Copy link
Contributor Author

bjee19 commented Apr 17, 2025

Will post a picture of the updated longevity dashboard soon.

@bjee19
Copy link
Contributor Author

bjee19 commented Apr 18, 2025

Created #3311 to track enabling upgrade nfr test for 2.1 release.

@bjee19
Copy link
Contributor Author

bjee19 commented Apr 18, 2025

image

Here is what the longevity dashboard looks like now, notably we are missing all of the nginx specific metrics. We now only have access the container cpu and memory.

Added an additional possible acceptance criteria to #1744 which describes why and would we could do to recover more graphs.

@bjee19 bjee19 marked this pull request as ready for review April 21, 2025 17:43
@bjee19 bjee19 requested a review from a team as a code owner April 21, 2025 17:43
@bjee19
Copy link
Contributor Author

bjee19 commented Apr 21, 2025

Functional tests do not pass, but the fix should come in when #3275 is merged where another volume is added for agent.

@bjee19 bjee19 requested a review from sjberman April 21, 2025 18:05
Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'm assuming all the results look as expected with the changes?

@bjee19
Copy link
Contributor Author

bjee19 commented Apr 21, 2025

@sjberman

Nice work! I'm assuming all the results look as expected with the changes?

Yep, i don't know if the automated github workflow will work, but manually running works and the results look as expected.

Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bjee19 bjee19 force-pushed the tests/update-nfr-cp-dp branch from 580823a to 627a31a Compare April 22, 2025 19:57
@bjee19 bjee19 force-pushed the tests/update-nfr-cp-dp branch from 627a31a to 05672e5 Compare April 22, 2025 19:58
@bjee19 bjee19 requested a review from sjberman April 22, 2025 22:25
@bjee19 bjee19 merged commit a816513 into change/control-data-plane-split Apr 22, 2025
44 checks passed
@bjee19 bjee19 deleted the tests/update-nfr-cp-dp branch April 22, 2025 23:35
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Apr 22, 2025
sjberman added a commit that referenced this pull request Apr 23, 2025
Update non-functional tests for the control plane data plane split.

Problem: The non-functional tests do not work for the control plane data plane split changes.

Solution: Update non-functional tests.

Testing: Scale, Reconfiguration, Performance, and Longevity tests work. Upgrade test doesn't work, however that is sort of planned since the CP/DP split is a breaking change of NGF and thus you can't easily upgrade with zero downtime.

---------

Co-authored-by: Saylor Berman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-chart Relates to helm chart tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants