-
Notifications
You must be signed in to change notification settings - Fork 114
CP/DP Split: optimize configuration events #3320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sjberman
merged 7 commits into
change/control-data-plane-split
from
chore/optimize-configapply
Apr 28, 2025
Merged
CP/DP Split: optimize configuration events #3320
sjberman
merged 7 commits into
change/control-data-plane-split
from
chore/optimize-configapply
Apr 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3320 +/- ##
===================================================================
- Coverage 89.74% 86.71% -3.03%
===================================================================
Files 109 129 +20
Lines 11150 14751 +3601
Branches 50 62 +12
===================================================================
+ Hits 10007 12792 +2785
- Misses 1083 1816 +733
- Partials 60 143 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ciarams87
approved these changes
Apr 28, 2025
Problem: All config update events resulted in sending configuration to every Gateway, even if the change was irrelevant. Solution: Compare new config with old config to determine if a ConfigApply is necessary. Simplified the change processor and handler to no longer have to determine this.
…write status earlier
This reverts commit f020a8e.
0245a61
to
d080064
Compare
bjee19
approved these changes
Apr 28, 2025
e2115c3
into
change/control-data-plane-split
36 of 37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: All config update events resulted in sending configuration to every Gateway, even if the change was irrelevant.
Solution: Compare new config with old config to determine if a ConfigApply is necessary. Simplified the change processor and handler to no longer have to determine this.
Testing: Verified that relevant Gateways are updated properly, otherwise no updates occur.
Closes #3272
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.