Skip to content

Update Gateway API to v1.3.0 #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Update Gateway API to v1.3.0 #3348

merged 2 commits into from
Apr 30, 2025

Conversation

ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Apr 30, 2025

Proposed changes

Problem: We don't support the latest version of the Gateway API

Solution: Update Gateway API to v1.3.0

Testing: Ran unit-tests and conformance tests locally

Please focus on: I've enabled the Request Mirroring conformance tests, but they are failing for me locally. Pushing them anyway for now, we can decide if we need to fix something on our side, or disable them for now

Closes #3316

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Updated Gateway API to v1.3.0

@ciarams87 ciarams87 requested a review from a team as a code owner April 30, 2025 14:51
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (39c3486) to head (67b7b4f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3348   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files         116      116           
  Lines       11928    11928           
  Branches       62       62           
=======================================
  Hits        10283    10283           
  Misses       1580     1580           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5
Copy link
Contributor

looks good to me, but request mirror conformance tests fail, so we might just have to remove them.

@sjberman why didn't we add them as part of your PR, am I missing something?

@sjberman
Copy link
Collaborator

@salonichf5 They were apparently bugged in the last release, but maybe there's still an issue. I verified that the functionality worked, but the tests weren't passing.

@salonichf5
Copy link
Contributor

@salonichf5 They were apparently bugged in the last release, but maybe there's still an issue. I verified that the functionality worked, but the tests weren't passing.

aah okay, makes sense now. We might just have to track the bug separately and add these then. I can open the issue, didn't find the bug in issues, can you point me towards it?

@sjberman
Copy link
Collaborator

@salonichf5 I had assumed kubernetes-sigs/gateway-api#3708 was a fix for the potential issue we were seeing.

Basically the tests couldn't see an expected log message, but I manually checked the logs and it existed. So something seemed wrong with the test.

@ciarams87
Copy link
Contributor Author

I'll disable them again and create a tracking issue @salonichf5 @sjberman

@ciarams87
Copy link
Contributor Author

Created #3350

@ciarams87 ciarams87 merged commit dbf1b14 into main Apr 30, 2025
40 checks passed
@ciarams87 ciarams87 deleted the feat/update-gateway-api branch April 30, 2025 19:20
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Gateway API to 1.3
4 participants