-
Notifications
You must be signed in to change notification settings - Fork 114
Update Gateway API to v1.3.0 #3348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3348 +/- ##
=======================================
Coverage 86.20% 86.20%
=======================================
Files 116 116
Lines 11928 11928
Branches 62 62
=======================================
Hits 10283 10283
Misses 1580 1580
Partials 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
looks good to me, but @sjberman why didn't we add them as part of your PR, am I missing something? |
@salonichf5 They were apparently bugged in the last release, but maybe there's still an issue. I verified that the functionality worked, but the tests weren't passing. |
aah okay, makes sense now. We might just have to track the bug separately and add these then. I can open the issue, didn't find the bug in issues, can you point me towards it? |
@salonichf5 I had assumed kubernetes-sigs/gateway-api#3708 was a fix for the potential issue we were seeing. Basically the tests couldn't see an expected log message, but I manually checked the logs and it existed. So something seemed wrong with the test. |
I'll disable them again and create a tracking issue @salonichf5 @sjberman |
223dcc1
to
67b7b4f
Compare
Created #3350 |
Proposed changes
Problem: We don't support the latest version of the Gateway API
Solution: Update Gateway API to v1.3.0
Testing: Ran unit-tests and conformance tests locally
Please focus on: I've enabled the Request Mirroring conformance tests, but they are failing for me locally. Pushing them anyway for now, we can decide if we need to fix something on our side, or disable them for now
Closes #3316
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.