Skip to content

Use proper internal GKE service annotation #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Jun 2, 2025

Problem: The service annotation for the GKE services was improperly formatted.

Solution: Fix the annotation so it provisions the proper service.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: The service annotation for the GKE services was improperly formatted.

Solution: Fix the annotation so it provisions the proper service.
@sjberman sjberman requested a review from a team as a code owner June 2, 2025 15:33
@github-actions github-actions bot added tests Pull requests that update tests helm-chart Relates to helm chart labels Jun 2, 2025
@sjberman sjberman closed this Jun 2, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jun 2, 2025
@sjberman sjberman deleted the tests/service-ip branch June 2, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-chart Relates to helm chart tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant