Skip to content

Cherry pick #3429 and #3431; longevity results and GKE annotation fix #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Jun 2, 2025

cherry picking longevity results and annotation fix to the release branch.

#3429
#3431

sjberman added 2 commits June 2, 2025 13:42
Adding longevity results for 2.0. These results are not complete and may be inaccurate. The tests were stopped early and the teardown scripts/functions did not collect everything properly.
Problem: The service annotation for the GKE services was improperly formatted.

Solution: Fix the annotation so it provisions the proper service.
@sjberman sjberman requested a review from a team as a code owner June 2, 2025 19:43
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests helm-chart Relates to helm chart labels Jun 2, 2025
@sjberman sjberman removed documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Jun 2, 2025
@sjberman sjberman changed the title Cherry pick #3429 and #3431 Cherry pick #3429 and #3431; longevity results and GKE annotation fix Jun 2, 2025
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (f06b10d) to head (4141c36).
Report is 1 commits behind head on release-2.0.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-2.0    #3437   +/-   ##
============================================
  Coverage        86.75%   86.75%           
============================================
  Files              127      127           
  Lines            15068    15068           
  Branches            62       62           
============================================
  Hits             13072    13072           
  Misses            1844     1844           
  Partials           152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman enabled auto-merge (squash) June 2, 2025 20:01
@sjberman sjberman merged commit b57bd3b into release-2.0 Jun 2, 2025
50 checks passed
@sjberman sjberman deleted the cherry-pick/longevity-and-nfr-label branch June 2, 2025 20:04
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants