Open
Conversation
Comment on lines
+450
to
+451
| client certificates. | ||
| client certificates. If provided, a CRL must be included for each | ||
| certificate in the certificate chain. |
Author
There was a problem hiding this comment.
Similar documentation exists in:
ngx_mgmt_modulengx_http_grpc_modulengx_http_oidc_modulengx_http_proxy_modulengx_http_uwsgi_modulengx_mail_ssl_modulengx_stream_proxy_modulengx_stream_ssl_modulengx_stream_zone_sync_module
Would it be good to make this change in those places as well?
Collaborator
There was a problem hiding this comment.
IMHO, it looks somewhat ambiguous wrt "each certificate", what about:
When using intermediate certificates, their CRLs should be specified in the same file.
(akin to the wording in ssl_certificate)
Author
There was a problem hiding this comment.
Oh nice. Yeah, I like that wording more. Updated.
This is just to help clarify that the CRL input must match the certificate chain, which was discovered from this stackoverflow: https://stackoverflow.com/questions/17086934/nginx-unable-to-get-certificate-crl
NeedleInAJayStack
force-pushed
the
docs/ssl-crl
branch
from
5dcb5e2 to
c71c3d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
closes #187
The
ssl_crldocumentation does not mention that a revocation list is required for every certificate in the certificate chain, which can cause confusion when using intermediate CAs. This forum post, this ticket and this stackoverflow that specify this requirement, but it seems like it would convenient to have it more visible in the official documentation.Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).