Update role to latest supported OSes and include license support#326
Open
aknot242 wants to merge 16 commits into
Open
Update role to latest supported OSes and include license support#326aknot242 wants to merge 16 commits into
aknot242 wants to merge 16 commits into
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the role to reflect the current set of supported NGINX App Protect WAF and DoS distributions, adds NGINX Plus JWT license support, and fixes a range of Molecule CI issues that prevented the test suite from running.
Features
jwtfield to thenginx_app_protect_licensevariable (required for NGINX Plus R33+). Updated main.yml, all Molecule converge.yml playbooks, and theREADMEto document the newNGINX_JWTenvironment variable for CI workflows.Enhancements
ansible.posix→ 2.0.0,community.general→ 10.7.0,community.crypto→ 2.26.2,community.docker→ 4.6.0.ansible_service_mgr→ansible_facts['service_mgr']andansible_python['version']['major']→ansible_facts['python']['version']['major']in task files.Bug Fixes
ANSIBLE_ROLES_PATH: Addedenv: ANSIBLE_ROLES_PATHto all Molecule scenarios (advanced,default,dos,specific-version,uninstall) so the role under test is correctly resolved during converge.remote_tmp: Addedremote_tmp: /tmp/.ansible/tmpto all scenarioprovisioner.config_options.defaultsto fix temporary directory creation failures in containers.ansible_python_interpreter: /usr/libexec/platform-pythonhost vars forrhel-8andoraclelinux-8in thedefaultscenario to prevent Ansible from selecting Python 3.11, which lacksdnfbindings on those platforms.CI/CD
ubuntu:focal,amazonlinux:2,alpine:3.17,rhel-ubi8:8.7) with currently supported ones.FROM --platform=linux/amd64to Dockerfile.j2 to ensure correct platform images are built when running Molecule on Apple Silicon (arm64) hosts.systemdandpython3-cryptographyto the dnf install layer in Dockerfile.j2 for Amazon Linux 2023 / RHEL-family containers.NGINX_JWThandling to all Molecule prepare playbooks (common/prepare.yml,advanced/prepare.yml,uninstall/prepare.yml).wait_for_connectionto prepare.yml to allow systemd to finish booting before Ansible connects.4.xto26.x.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentdefaults/main.yml,README.mdandCHANGELOG.md)