Merge pull request #90 from jonstacks/fix-notes-txt

🐛 Fix rending of NOTES.txt

helm/ingress-controller/CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.3.1
+### Fixed
+- Fixes rendering of `NOTES.txt` when installing via helm
+
 ## 0.3.0
 ### Changed
 

helm/ingress-controller/Chart.yaml

@@ -1,7 +1,7 @@
 apiVersion: v2
 name: ngrok-ingress-controller
 description: A Kubernetes ingress controller built using ngrok.
-version: 0.3.0
+version: 0.3.1
 appVersion: 0.2.0
 keywords:
   - ngrok

helm/ingress-controller/templates/NOTES.txt

@@ -8,10 +8,12 @@ be automatically configured on the internet using ngrok.
 
 {{- $found := false }}
 {{- range $svcIndex, $service := (lookup "v1" "Service" "" "").items }}
+  {{- if not $found }}
     {{- range $portMapIdx, $portMap := $service.spec.ports }}
-        {{- if eq $portMap.port 80 443 }}
-          {{- if ne $service.metadata.name "kubernetes" }}
-            {{- $randomStr := randAlphaNum 8 }}}}
+      {{- if eq $portMap.port 80 443 }}
+        {{- if ne $service.metadata.name "kubernetes" }}
+          {{- $found = true -}}
+          {{- $randomStr := randAlphaNum 8 }}
 
 One example, taken from your cluster, is the Service:
    {{ $service.metadata.name | quote }}
@@ -39,12 +41,10 @@ spec:
 --------------------------------------------------------------------------------
 Applying this manifest will make the service {{ $service.metadata.name | quote }}
 available on the public internet at "https://{{ $service.metadata.name -}}-{{- $randomStr -}}.ngrok.io/".
-
-                {{- $found = true -}}
-            {{- end }}
         {{- end }}
+      {{- end }}
     {{- end }}
-    {{- if eq $found true }}{{break}}{{end}}
+  {{- end}}
 {{- end }}
 
 Once done, view your edges in the Dashboard https://dashboard.ngrok.com/cloud-edge/edges