Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AgentEndpoint client certs for upstream #594

Merged
merged 7 commits into from
Feb 24, 2025

Conversation

Alice-Lilith
Copy link
Contributor

Adds support to AgentEndpoint for specifying a list of client certificates to use with the upstream and adds translation support from Gateway API Gateway.Spec.BackendTLS.ClientCertificateRef.

@github-actions github-actions bot added area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart labels Feb 21, 2025
@Alice-Lilith Alice-Lilith force-pushed the alicewasko/upstream-client-certs branch from 84e7d80 to 3acf18e Compare February 21, 2025 00:33
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 41.47287% with 151 lines in your changes missing coverage. Please review.

Project coverage is 29.21%. Comparing base (5313c66) to head (69e5511).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rnal/controller/agent/agent_endpoint_controller.go 0.00% 85 Missing ⚠️
internal/controller/gateway/gateway_controller.go 0.00% 30 Missing ⚠️
api/ngrok/v1alpha1/zz_generated.deepcopy.go 0.00% 17 Missing ⚠️
pkg/tunneldriver/driver.go 25.00% 9 Missing ⚠️
internal/ir/ir.go 0.00% 6 Missing ⚠️
pkg/managerdriver/controller-handler.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   29.01%   29.21%   +0.19%     
==========================================
  Files          92       92              
  Lines       14358    14551     +193     
==========================================
+ Hits         4166     4251      +85     
- Misses       9949    10053     +104     
- Partials      243      247       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alice-Lilith Alice-Lilith marked this pull request as ready for review February 21, 2025 02:47
@Alice-Lilith Alice-Lilith requested a review from a team as a code owner February 21, 2025 02:47
@jonstacks jonstacks added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 11ffcc9 Feb 24, 2025
10 checks passed
@jonstacks jonstacks deleted the alicewasko/upstream-client-certs branch February 24, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants