Skip to content

SiglentFunctionGenerator: only update frequncy if actually changed #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SiglentFunctionGenerator: only update frequncy if actually changed #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scopehal/SiglentFunctionGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,10 @@ float SiglentFunctionGenerator::GetFunctionChannelFrequency(int chan)

void SiglentFunctionGenerator::SetFunctionChannelFrequency(int chan, float hz)
{
if(m_cachedFrequencyValid[chan] && std::abs(m_cachedFrequency[chan] - hz) < 1e-6)
{
return;
}
m_transport->SendCommandQueued(m_channels[chan]->GetHwname() + ":BSWV FRQ," + to_string(hz));

m_cachedFrequency[chan] = hz;
Expand Down
2 changes: 1 addition & 1 deletion scopehal/SiglentFunctionGenerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class SiglentFunctionGenerator : public virtual SCPIFunctionGenerator

//Config cache
bool m_cachedFrequencyValid[2];
int64_t m_cachedFrequency[2];
float m_cachedFrequency[2];
bool m_cachedEnableStateValid[2];
bool m_cachedOutputEnable[2];
bool m_cachedAmplitudeValid[2];
Expand Down