Feat/add control errors in forms events #586
Conversation
| startWith(form), | ||
| map(() => { | ||
| if (form instanceof FormGroup) { | ||
| return errorsEvents$(form); | ||
| } | ||
| if (form instanceof AbstractControl) { | ||
| return errorsEvents$(form); | ||
| } | ||
| return null; | ||
| }), | ||
| ), |
There was a problem hiding this comment.
question: why do we startWith(form)?
There was a problem hiding this comment.
I needed it to emit a value for combineLatest to ensure that I could capture an error when initializing the form. However, I realized that using startWith(null) achieves the same result.
| @@ -55,6 +56,25 @@ function pristineEvents$<T>(form: AbstractControl<T>) { | |||
| ); | |||
| } | |||
|
|
|||
| function errorsEvents$(form: FormGroup | AbstractControl) { | |||
There was a problem hiding this comment.
nit: errorsEvents$ should be Observable like other Events$ for consistency
There was a problem hiding this comment.
Thanks for the feedback! I have moved the logic to errorsEvent, and it now returns an observable
| formTyped$ = allEventsObservable<ReturnType<typeof this.form.getRawValue>>( | ||
| this.form, | ||
| ); | ||
| $formTyped = allEventsSignal<ReturnType<typeof this.form.getRawValue>>( | ||
| this.form, | ||
| ); | ||
| ngOnInit() { | ||
| this.controlData$ = allEventsObservable<string>(this.control); |
There was a problem hiding this comment.
nit: IMO these can be lifted out of the ngOnInit into the class fields and without the injector. No need for the lifecycle hook and !/any, more declarative.
There was a problem hiding this comment.
I completely agree. I just created that example to verify that it would work with the injector in the case of signals. I can fix it.
Description
Hello,
FormEvents is a great utility. However, I also wanted a way to determine which controls have errors and the specific error types. To achieve this, I have added controlErrors, which returns a Record<string, string>.
I have updated the tests to ensure the expected values are correctly validated.
PS: This is my first contribution to open source! 🚀
Let me know if any changes are needed.