Fix len parameter handling: Unit tests for gRPC ,interpretor and session#2165
Open
Fix len parameter handling: Unit tests for gRPC ,interpretor and session#2165
Conversation
unit tests for session and grpc along with nifake.proto changes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2165 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 71 71
Lines 18675 18682 +7
=======================================
+ Hits 16830 16838 +8
+ Misses 1845 1844 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
This PR continues the work from Fixing size parameter handling.
It includes the following changes:
MixedIviDanceAndLenMechanism, to validate mixed size mechanisms:nifake.prototo include new methods ('MixedIviDanceAndLenMechanism' and 'MultipleArraysDifferentSize').List issues fixed by this Pull Request below, if any.
None
What testing has been done?
MultipleArraysDifferentSizetest_multiple_arrays_different_size: forwards both arrays with correct sizestest_multiple_arrays_different_size_none_input: forwardsNonecorrectly and treats size as0test_multiple_arrays_different_size: driver call receives both arrays with expected size argumentstest_multiple_arrays_different_size_none_input: one array is passed asNonewith size0test_multiple_arrays_different_size_none_input: session forwardsvalues_arrayandNoneunchanged to interpreterMixedIviDanceAndLenMechanismtest_mixed_ivi_dance_and_len_mechanism: verifies request mapping for a mixed-mechanism API (len-sized input array in grpc request for a method that also uses IVI-dance output behavior).test_mixed_ivi_dance_and_len_mechanism: verifies IVI-dance two-call pattern