fix: fence prekey persist against panic wipe race (#70) - #74
Open
chtnnh wants to merge 3 commits into
Open
Conversation
Invalidate and drain in-flight persistPrekeys before wipeEverything, and wrap prekey table replaces in exclusive transactions so a stale snapshot cannot resurrect wiped OTK/SPK secrets. Co-authored-by: Cursor <cursoragent@cursor.com>
CI's `npx expo install --check` started failing after upstream SDK 57 patch bumps (expo ~57.0.8 and related packages). Co-authored-by: Cursor <cursoragent@cursor.com>
Lock @napi-rs/wasm-runtime's @emnapi/core and @emnapi/runtime peers at the top level so CI's npm ci does not demand an unlocked 1.11.2. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenerationQueueso panic wipe can invalidate + drain in-flightpersistPrekeysbeforewipeEverything.identityRef/onPrekeysChangedat wipe start so periodic sync cannot start a fresh persist mid-wipe.saveLocalPrekeys/savePeerPrekeysinwithExclusiveTransactionAsync(same pattern as wipe).onPrekeysChangedafter successful re-provision.Closes #70
Test plan
npm test/npm run typecheck(GenerationQueue interleaving cases)receive_keys/one_time_keysempty until fresh provision